Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace black with ruff #1968

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

mjurbanski-reef
Copy link
Contributor

@mjurbanski-reef mjurbanski-reef commented Jun 1, 2024

ruff implements black code style, but has two advantages:

  • it is much faster
  • and MUCH more important: it also is a linter with autofixer - i.e. instead of bothering you with stuff like instead of obj == None use obj is None - it will just automatically fix it for you speeding up development .

This PR only replaced the formatter, just to test the waters as ruff linter will for sure be bigger with all its autofixers :)
If you want to know more about ruff see rules it implements and which have autofixes available - my recommendation would be to stick with ["E", "F", "I", "UP", "TCH005"] for starters.

@gus-opentensor gus-opentensor merged commit 28b9039 into opentensor:staging Jun 3, 2024
12 checks passed
This was referenced Jun 4, 2024
@gus-opentensor gus-opentensor mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants